Move react and react-dom to peerDependencies from dependencies
Closed this issue · 4 comments
acherkashin commented
Recently we've decided to use React version of cheetah-grid as we previously used a vanilla version, it works perfectly for us 👍
We are using react 18, and noticed in pnpm-lock.yaml appeared react-17.
I've looked at package.json of cheetah-grid-react and noticied that react is specified as dependency there
I think we should specify react as peerDependency instead.
Moreover, we should allow react version >= 17.
ota-meshi commented
@shibukawa Is it possible to change dependencies?
acherkashin commented
@ota-meshi do you want me to send a pull request?
ota-meshi commented
Yeah! Pull requests are welcome. Thank you.
acherkashin commented
@ota-meshi I've created pull request #420