futurefirst/uk.org.futurefirst.networks.civipoints

If a contact has no points of one type, but has points of another type, no tabs show

Closed this issue · 4 comments

Suppose there are 3 types of points. A contact has never had any points of type 1 but has some of type 2 and some of type 3. None of the tabs show up.

If some points of type 1 are then granted to the contact, all the tabs show up.

The hook civipoints_civicrm_tabs is bombing out early. There is a return that should be a continue when checking whether a contact has had points of each type.

@davidknoll In my view - this is the wrong approach to showing the tab. I think that points should be connected to a type of contact (i.e. Student, School) and then display for contacts of that type regardless of if points have been added or not.

Just an opinion :)

I think we talked about that at the sprint, it's already a future enhancement: #5

So it is - nice one!

On Fri, Nov 20, 2015 at 4:06 PM, David Knoll notifications@github.com
wrote:

I think we talked about that at the sprint, it's already a future
enhancement: #5
#5


Reply to this email directly or view it on GitHub
#8 (comment)
.