IOS 13 PSRadioGroupSpecifier
boblepepeur opened this issue · 4 comments
boblepepeur commented
Hello,
After update POD on IOS 13 i get errors with all my PSRadioGroupSpecifier
The error is located on file IASKAppSettingsViewController.m line 687 [_selections[indexPath.section] updateSelectionInCell:cell indexPath:indexPath];
After investigations, on same file, I change that part :
- (void)createSelections {
NSMutableArray *sectionSelection = [NSMutableArray new];
for (int i = 0; i < _settingsReader.numberOfSections; i++) {
IASKSpecifier *specifier = [self.settingsReader headerSpecifierForSection:i];
if ([specifier.type isEqualToString:kIASKPSRadioGroupSpecifier]) {
IASKMultipleValueSelection *selection = [[IASKMultipleValueSelection alloc] initWithSettingsStore:self.settingsStore];
selection.tableView = self.tableView;
selection.specifier = specifier;
selection.section = i;
[sectionSelection addObject:selection];
} else {
[sectionSelection addObject:[NSNull null]];
}
}
_selections = sectionSelection;
}
with
- (void)createSelections {
NSMutableArray *sectionSelection = [NSMutableArray new];
NSInteger sectionsNumber = self.settingsReader.numberOfSections;
for (int i = 0; i < sectionsNumber; i++) {
IASKSpecifier *specifier = [self.settingsReader headerSpecifierForSection:i];
if ([specifier.type isEqualToString:kIASKPSRadioGroupSpecifier]) {
IASKMultipleValueSelection *selection = [[IASKMultipleValueSelection alloc] initWithSettingsStore:self.settingsStore];
selection.tableView = self.tableView;
selection.specifier = specifier;
selection.section = i;
[sectionSelection addObject:selection];
} else {
[sectionSelection addObject:[NSNull null]];
}
}
_selections = sectionSelection;
}
futuretap commented
Which errors do you see? Build or runtime errors?
Can you provide a sample project demonstrating the issue? The IASKSampleApp works fine and doesn't have build errors.
boblepepeur commented
did you try to build with XCode 11?
… Le 11 oct. 2019 à 12:29, Ortwin Gentz, FutureTap ***@***.***> a écrit :
Which errors do you see? Build or runtime errors?
Can you provide a sample project demonstrating the issue? The IASKSampleApp works fine and doesn't have build errors.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#421?email_source=notifications&email_token=ABABWDBX7IAGLHZYVY4L3U3QOBIQ7A5CNFSM4IZLYK7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA7SPYA#issuecomment-541009888>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABABWDD5WVX4OPRCZOMRSD3QOBIQ7ANCNFSM4IZLYK7A>.
diederich commented
@boblepepeur https://travis-ci.org/futuretap/InAppSettingsKit/jobs/586970726 seems to be building the Sample App with Xcode 11, yeah
futuretap commented
Don't see any build errors using Xcode 11.4 (11E146). Closing for now…