Does transactional_civicrm_buildForm need a filter?

Just doing a quick review of this extension before trying it out. It looks nice.

Looking at the implementation of hook_civicrm_buildForm, I'm not sure what the contact ID is being stashed away for but I'm not sure that it should be stashed on every form load.

Any thoughts on why this is happening?

@jitendrapurohit? I see that this is being used here

nz.co.fuzion.transactional/CRM/Mailing/Transactional.php

Line 130 in 7ad93aa

// lets see if a form was submitted with a contact that has this email address

Which seems to date back to the initial set up.

it is then used here:

nz.co.fuzion.transactional/CRM/Mailing/Transactional.php

Line 292 in 7ad93aa

list($contact_id, $email_id) = $this->getContactAndEmailIds($params);

Maybe the problem was that it is hard to identify all the places where that form is used? Or maybe it wasn't that hard and the original author just didn't get round to adding the filter.

Yes, agree with the filters that need to be included in the buildform hook. I've included the fix in the latest update done to the extension code ebb9b19#diff-93be7aa95164c9d34275cc856f8ee88dR97. Thanks for raising @michaelmcandrew

@jitendrapurohit - great - thanks! I did try and fix this myself but was not 100% sure what forms would need to be included.