fylgja/fylgja

Using / for division outside of calc() is deprecated

jissereitsma opened this issue · 4 comments

When compiling sources I'm bumping into multiple deprecation warnings with text Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0 because of lines like the following:

margin-left: ($x / -2);

Reference: https://sass-lang.com/documentation/breaking-changes/slash-div

I think this can simply be refactored into calc($x / -2) or so.

Weird I thought got ride of this, not sure which component is still using the older syntax.

Personally I don't have these warning anymore, using just sass, but I will investigate this.

@jissereitsma can you share me you environment details, sass version and type node or dart also if you're using webpack or something else

I'm using @fylgja/auto-grid 1.1.0, @fylgja/base 1.1.1 and fylgja 1.2.1. I tried upgrading to version 3.0.0 (which I can see as a GitHub tag here) but this is not available via NPMJS. However, I also upgraded @fylgja/flex-grid to 3.0.0 (which did work) and this fixed this issue.

I'll keep this issue open for just one question: How come is the GitHub tag here 3.0.0 but it's not reflected in the package on NPMJS?

Ah yes the flex grid is not part of the main bundle/repo.

You can find it here https://github.com/fylgja/fylgja-flex-grid and there is a npm version 3 so I am not sure what is going wrong.

From version 3 of the flex grid, it is usable in the newer sass versions (dart).
Any older version of the flex grid still uses the older node sass syntax that's why.

Moving this issue to the discussions for others to see 😉