fzyzcjy/flutter_rust_bridge

`implements` missing

Closed this issue · 6 comments

Larpoux commented

Hi, Guys, Girls and Ladyboys. I have bad news for you : I am back!!! 👀 .

No, I am kidding. I have finished to port my project implementation on Javascript, and I return to Rust to have a native implementation of my interface.

Actually I have something weird :

pub trait AudioScheduledSourceNode: AudioNode {
...

generates :

abstract class AudioScheduledSourceNode {

Without specifying implements AudioNode. Do you have any idea of the reason ?

fzyzcjy commented

Hi, happy to see you back!

Without specifying implements AudioNode

Firstly, does it work before (i.e. in some other code)? If no, then I guess this is a not-yet-implemented feature. If yes then it is a bug.

To implement it, we can either do it fully automatically (i.e. parse the parent trait name etc), or we can add something like #[frb(dart_implements = "AudioNode")] to allow users to add arbitrary implements or extends etc. I personally think the latter is needed because there can be other cases when we want a custom implements/extends.

raphaelrobert commented

I second that having something like #[frb(dart_implements = "ClassName")] and #[frb(dart_extends = "ClassName")] would generally be very useful.

  • 😄1
fzyzcjy commented

@Larpoux @raphaelrobert Feel free to PR! Alternatively, I will work on it in the next batch.

Larpoux commented

I am busy working on a port of the rust library to dart.
Actually I am not completely sure that there is real problem with this issue.
I will let you know later how things are going. Don’t do anything until I confirm the issue.

fzyzcjy commented

Ok, no worries and feel free to ping me when needed!

github-actions commented

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.