puppeteer should be a peer-dependency
transitive-bullshit opened this issue · 3 comments
transitive-bullshit commented
this allows users to specify which version of puppeteer they want to use, and this lib just has to state which versions of puppeteer it supports.
in general, large third-party dependencies like puppeteer are usually better off being peer deps.
g-plane commented
Have you checked the package.json
of Rize? Puppeteer is already as a peer dependency.
transitive-bullshit commented
Weird, I'm using a chrome extension which lists deps/peerdeps/devdeps on GH pages, and it was wrong, but the package.json is definitely correct. Sorry about that!
Also, I'll add rize to awesome-puppeteer shortly; just need to finish some work stuff up first.
g-plane commented
Thanks!