ga-wdi-boston/browser-template-ARCHIVED

change config.apiOrigin to config.host (or better name)?

Opened this issue · 3 comments

It can be confusing that config.apiOrigins exists in the config.js file but the key you use to build out the ajax URL is config.apiOrigin

gaand commented

No to config.host. That misses the point entirely.

Please think through why I might have chosen these names.

It's assigning ONE of the urls from the apiOrigins object to BE the apiOrigin. I get it, just seems like there may be a better name for it once it's finalized? #namingThingsIsHard

gaand commented

Too true. But naming things poorly is easy 🤖

host is inspecific. I'm okay with finding a better name than what's used for either key.