gab-k/RP2040-Decoder

Incorrect parameter passed

Closed this issue · 1 comments

I'm developing a STM32L151 based dcc decoder and was looking at your code as a possible starting point. Your project looks great and the pid control is a bit beyond my understanding. However, I did notice a slight error on the line below which you may like to correct.

pid->msr_total_iterations,

I believe it should have passed msr_delay_in_us not msr_total_iterations. It works at the moment because these two numbers have the same value of 100.

gab-k commented

You are correct that line is incorrect. Thanks for bringing it to my attention.