Definition of rotation_frequency_tor_sonic in core_profile
Closed this issue · 4 comments
Talking to @bclyons12 he confirmed that the (1/2pi) factor is needed, and he suggested that the GACODE website should be updated to say “poloidal flux per radian". Ping @jcandy .
In practice, I think what this means is that we should update https://github.com/gafusion/omas/blob/master/omas/omas_cocos.py with a new transforms['TOR_dPSI'] = sigma_B0_eff * sigma_Ip_eff * sigma_Bp_eff / (2 * numpy.pi) ** exp_Bp_eff and assign the TOR_dPSI to rotation_frequency_tor_sonic
Line 203 in 6e14e73
@bclyons12 do you agree?
These changes should be transparent in OMFIT, since conversion from/to ODS is done using automated COCOS transform. However we should be aware that this will affect any ODS that was saved, in the sense that the convention for those old ODSs would be different than the new ones.
Yes, this is described in Sec 2.2.3 of the GYRO technical manual (see image). Where exactly does it need to be fixed in the GACODE pages? I see one place after poking around.
@jcandy It's mistaken in the last sentence of "Sonic rotation formalism" here https://gafusion.github.io/doc/rotation.html#sonic-rotation-formalism
OK, that's the one I saw. LMK if you see any other issues.
This issue has not seen any activity in the past 60 days. It is now marked as stale and will be closed in 7 days if no further activity is registered.