galehouse5/skribbl-io-autodraw

Colors are bad

Closed this issue · 9 comments

Green doesn't ever get drawn. Probably some bug in the color distance. I took some code from online and put it together to get a good color distance. see gellyfisher patch 1 branch

blue is never drawn either

Thanks, @gellyfisher. I'm having trouble reproducing green not drawing. Can you attach an image that demonstrates the problem?

I'll draw this color gradient in skribbl.io:
image

Here is the existing color distance function:
image

Here is the color distance function you propose:
image

I'm happy to change the color distance function to improve accuracy. I'm having trouble deciding whether the proposed function is an improvement though. Can you help convince me?

@FreePvp, can you attach an image that demonstrates blue not drawing when it should?

Also seems like lots of pink, but idk, heres a sans image vs what it draws:

no blue
No blue eye

Yeah that and I get this orange instead of green if I use your code (I changed the drawing order though so that it's less messy)
yours
while if I use my code (https://github.com/gellyfisher/skribbl-io-autodraw/blob/master/color-helper.js) then I get
mine

Thanks! I'll investigate further.

Yeah that and I get this orange instead of green if I use your code (I changed the drawing order though so that it's less messy)
yours
while if I use my code (https://github.com/gellyfisher/skribbl-io-autodraw/blob/master/color-helper.js) then I get
mine

I tried out your code and get more detailed images, still missing blues.
no blue detailed

Its not perfectly blue either in the original. Maybe theres just not a color that's close to its eye color? Maybe try to use something more colorful for testing

Using CIEDE2000 now:

image

image

Light shades of blue resolve to light gray:

image

Not perfect.