gamechanger/lox

Review comments

Closed this issue · 2 comments

  • Let's put everything which isn't the main entrypoint lox.js file in a lib subfolder (and do a similar thing with the structure of our test folder.
  • I'm guessing the reason you're doing var testKey = uuid.v1(); in each test is to avoid collision? Let's do this better and clean up after ourselves. Use beforeEach and afterEach to setup and teardown the redis data we need and leave the DB as we found it.
  • Duplicate test in lox_test.js
  • Consider using supertest to make testing more concise
  • Let's rip out the token thing
  • A quick comment on each function explaining what it does would be useful for the next person. Maybe find a lib to make this easier to publish?
  • We probably want to enable timestamps in our logs
  • Probably worth fleshing out the package.json a little more with a better description, author.
  • Add some basic details to the readme.md. Eventually I'd like this to describe what the service does, how to use it, and provide examples. For now, some short instructions on how to get it running should suffice.
  • There are a few places missing semi colons according to my linter. There must be a JS linter for emacs...

Donezo