CI tests fails in GAP 4.11
Closed this issue · 1 comments
testing: /tmp/gaproot/pkg/PackageManager/tst/Interactive.tst
1 ms (0 ms GC) and 43.7KB allocated for Interactive.tst
testing: /tmp/gaproot/pkg/PackageManager/tst/PackageManager.tst
gap: 'tcsetattr' could not turn off raw mode!
########> Diff in /tmp/gaproot/pkg/PackageManager/tst/PackageManager.tst:54
# Input is:
InstallPackage("matgrp");
# Expected output:
true
# But found:
#I Package availability test failed
false
########
########> Diff in /tmp/gaproot/pkg/PackageManager/tst/PackageManager.tst:56
Clearly this is because matgrp
now requires GAP 4.12.
So perhaps a different package can be picked? I don't know why matgrp was used in the first place. If the idea was to use a package that is not shipped with GAP, that's moot because matgrp now is part of the GAP package distro. If this was the intention, I think instead we need a dedicated package just created for testing PackageManager. That wouldn't be hard to get, anyway, as we can just use PackageMaker to create one or multiple such packages.
Or perhaps we can just plug in any package here... ?
Perhaps @mtorpey has thoughts on ths.
PS: there is a weird gap: 'tcsetattr' could not turn off raw mode!
which one may wish to look into as well, but for now it doesn't matter for the issue at hand
Thanks for working this out!
matgrp was, I believe, chosen pretty much at random in order to test that installation works. I tried to use a range of real live packages for this, in order to verify that this really works with real packages. But as you've spotted, this does make the tests hard to maintain. It might be worth using the example
package in a few more places, or creating new test packages as you mentioned.
For now, #111 (using the format
package) looks like a good approach. I'd be happy to merge it when the tests pass.