Dependency on package cryst
Closed this issue · 7 comments
The function LinearRepresentationOfStructureGroup uses this package. Would it be possible to exclude this function if the package is not there? In any case, cryst should be loaded before YangBaxter.
Then what about #58? Cryst does not require compilation, so it should be runnable anywhere.
We decided to make the package suggested, and load the function dependently on whether it is available or not. I will implement this.
@vendramin Removing LinearRepresentationOfStructureGroup will further require to remove IYBBrace. One more time, I have doubts - do we really want to make both of these optionally available?
First of all, the description of this task is perhaps outdated. It is IYBBrace which uses functions from Cryst:AffineCrystGroupOnLeft, PointGroup and PointHomomorphism.
But the main point is that Cryst is redistributed with GAP, and has no non-standard dependencies (it requires polycyclic package, and both do not require compilation). So it will be much simpler to merge #58 rather than conditionally load some code...
@vendramin see now new #77 by @fingolfin please - as I said above, Cryst is redistributed with GAP, and has no non-standard dependencies (it requires polycyclic package, and both do not require compilation). So it will be much simpler to merge #77 rather than conditionally load some code...
Closed by #77 - thanks @fingolfin