Failures in the tests on GitHub Actions
Closed this issue · 4 comments
olexandr-konovalov commented
@vendramin #72 restores CI using GitHub actions, so we have automated tests again. A couple of tests are failing. This could mean something serious:
########> Diff in /home/runner/work/YangBaxter/YangBaxter/gaproot/pkg/YangBaxt\
er/tst/testinstall/cycleset.tst:28
# Input is:
List([1..8], k->NrSmallCycleSets(k));
# Expected output:
[ 1, 2, 5, 23, 88, 595, 3456, 34528 ]
# But found:
[ 1, 2, 5, 23, 88, 595, 3456, 34530 ]
########
but the other should be easy to fix:
########> Diff in /home/runner/work/YangBaxter/YangBaxter/gaproot/pkg/YangBaxt\
er/tst/testinstall/skew.tst:158
# Input is:
Matrix(Brace2CycleSet(br));
# Expected output:
[ [ 1, 2, 3, 4, 5, 6, 7, 8 ], [ 1, 2, 3, 4, 5, 6, 7, 8 ],
[ 1, 2, 3, 4, 5, 6, 7, 8 ], [ 1, 2, 3, 4, 5, 6, 7, 8 ],
[ 1, 2, 3, 4, 7, 8, 5, 6 ], [ 1, 2, 3, 4, 7, 8, 5, 6 ],
[ 1, 2, 3, 4, 7, 8, 5, 6 ], [ 1, 2, 3, 4, 7, 8, 5, 6 ] ]
# But found:
[ [ 1 .. 8 ], [ 1 .. 8 ], [ 1 .. 8 ], [ 1 .. 8 ], [ 1, 2, 3, 4, 7, 8, 5, 6 ],
[ 1, 2, 3, 4, 7, 8, 5, 6 ], [ 1, 2, 3, 4, 7, 8, 5, 6 ],
[ 1, 2, 3, 4, 7, 8, 5, 6 ] ]
########
(this happens in some versions of GAP but not in the others)
vendramin commented
The first problem is because I found two solutions they were not considered by Etingof, Schledler and Soloviev. These new numbers are correct.
olexandr-konovalov commented
Ok, then I can update the test. For the 2nd problem, I can look at checking the output in a way which expands ranges to lists.
vendramin commented
Yes, please, update the tests.
olexandr-konovalov commented
@vendramin done!