gaplo917/Ligatured-Hack

Latest release missing many Fira Code ligatures

swrobel opened this issue · 3 comments

HackLigatured-v3.003+FC5.2+JBMv1.0.6
macOS 10.14.6
Tested in both VSCode & Atom

Showing the Fira showcase (I've tested both the CCG & regular versions, and they are the same):
Screen Shot 2020-06-16 at 7 40 47 AM

Stock Fira Code 5.2:
Screen Shot 2020-06-16 at 7 44 00 AM

Compare vs latest JBM:
Screen Shot 2020-06-16 at 7 41 09 AM

@swrobel Thanks for reporting!

After some investigations, I checked that .ttf -> .otf conversion is okays.

Seems like FIRA Code v5 changed the way(standard?) to add the ligatures. That's why a portion of ligatures are affected.

Need more time to see how to fix.

@swrobel
According to the comment of Fira Code author, Fira code changed the way to add ligatures.

This change added lots of difficulties in extracting ligatures from Fira Code. The fastest way to get the correct Hack font patched with Fira Code is to fallback to Fira Code v3.1.