garbas/vim-snipmate

{VISUAL} adds one extra line

janko opened this issue · 3 comments

janko commented

After trying out the fix for #177, I realized that there is one extra space being added below {VISUAL} (I think this was already before, but I forgot to report it).

Let's say I have the same snippet and code as in the above mentioned issue. I expect to end up with this:

*cursor*
  class Foo
  end
end

But instead I end up with this:

*cursor*
  class Foo
  end

end
ajzafar commented

I noticed this when I was working on #177. It only happens when you use visual line select (since that includes that last newline). I considered always removing the last newline in the visual selection, but I'm not sure that's correct. If anyone has a good argument for this, please share it. In the meantime, I'm going to think about it for a bit before deciding. I'm leaning towards it though.

ajzafar commented

I went ahead and did it.

janko commented

Thank you! Yeah, I think that everyone will be using snippets from visual-line mode, so I think it really makes sense.