garimasingh128/gitsetgo

Optimising css and better organisation throughout the app

garimasingh128 opened this issue · 5 comments

We should not write CSS using style={}
We could either write CSS in js using a third-party library like emotion-js or styled-components
or we can write traditional CSS using .css or .scss file. for this approach, we can have a better folder structure like

components/
DispalyCard

  • displaycard.js
  • displaycard.css
    Footer
  • footer.js
  • footer.css

@garimasingh128 can you pls let me know what CSS approach we need in this project?

You need to separate the CSS defined in the components into seperate JS and CSS files.
For ex:
you will create a folder in components:
DisplayCard
|- DisplayCard.js
|- DisplayCard.css

Like this for every component.

Can I work on this ? I'm quite new to the open source project but I will try my best 😀

All the best buddy

Please review my PR #113 😄