Issue with Makefile since upgrading to GNU make 4.4

Question

Issue with Makefile since upgrading to GNU make 4.4

Closed this issue a year ago · 13 comments

Looking at upgrading GNU make in OpenBSD to 4.4, but ran into only one port that seemed to break. Looking at the build logs it noticed a message during install stage.. "warning: pattern recipe did not update peer target". OpenBSD is using 2.18.11 at the moment.

ocamlfind: sourceView2Enums.ml: No such file or directory

Looking at the release notes there is an entry for this message..

WARNING: Future backward-incompatibility!
In the NEXT release of GNU Make, pattern rules will implement the same
behavior change for multiple targets as explicit grouped targets, below: if
any target of the rule is needed by the build, the recipe will be invoked if
any target of the rule is missing or out of date. During testing some
makefiles were found to contain pattern rules that do not build all targets;
this can cause issues so we are delaying this change for one release cycle
to allow these makefiles to be updated. GNU Make shows a warning if it
detects this situation: "pattern recipe did not update peer target".

brad0 commented a year ago

ping.

Answer 1 · 2022-12-16T11:20:25.000Z

Also on NixOS. But lablgtk 3.1.3 doesn't seem to suffer from this.

Answer 2 · 2022-12-22T22:38:15.000Z

I don't see any relevant changes with 2.18.13. It didn't make any difference.

Answer 3 · 2022-12-26T10:00:54.000Z

Indeed, 2.8.13 fixed incompatilities with ocaml 5.0, not with gmake.
I'll look into this.

Answer 4 · 2023-01-10T20:40:56.000Z

I'll look into this.

Able to look into this?

Answer 5 · 2023-01-12T00:54:52.000Z

Actually, I started looking into, but have a hard time reproducing.
With macports, the gmake version is 4.3 so I don't get an error. Is there a way to force gmake 4.3 to fail in such cases?
Also, does the failure happen always, or only in certain conditions?

Answer 6 · 2023-01-13T02:14:04.000Z

It happens every time. I only see this with 4.4. We are using 4.3 at the moment.

Answer 7 · 2023-01-20T10:24:04.000Z

I'm not a MacPorts user, but I noticed that up to date MacPorts beyond the 1.8.0 release has had GNU make 4.4 since Nov 2022.

Answer 8 · 2023-01-21T07:07:22.000Z

Thank you for the information.
I'll check how to install it.

Answer 9 · 2023-02-21T08:03:28.000Z

I did try using gmake 4.4 under macos.
I do indeed get the warning, but compilation proceeds without problem.
So what needs to be fixed ?
Does this mean that problems will only start to appear with gmake 4.5 ? or gmake 5.0 ?

Answer 10 · 2023-03-28T03:22:42.000Z

It will start with 4.4.0 or newer.

Anyway, I can't seem to find the repo or branch for lablgtk2. There is a patch to fix the build issue.

Answer 11 · 2023-03-30T01:45:38.000Z

This is a bit confusing, but the branch for lablgtk2 is master.

Answer 12 · 2023-03-31T23:29:56.000Z

I submitted a PR. The message "warning: pattern recipe did not update peer target" appears to be a red herring. It does not appear to be connected to the root issue.