garrytrinder/msteams-azure-search-openai-demo

AAD Auth for the demo

Opened this issue · 11 comments

vrajroutu commented

This will not work when AAD auth is enabled for the demo app. Can you also add that as an option may be?

garrytrinder commented

Thanks for the suggestion @vrajroutu

That's correct, currently the app assumes that the API endpoint is open. However, this is something that we should be able to include.

The instructions on the repo suggest adding authentication to the app service using the below tutorial so we should stick to this approach.

https://learn.microsoft.com/azure/app-service/scenario-secure-app-authentication-app-service

rglobisch-bpc commented

Hi, is there any guidance on how to handle the authentication from the bot side?

  • 👍1
garrytrinder commented

Hey @rglobisch-bpc 👋

I'm working on it, the code is done and being tested. Just need to document the steps for using the app with both non-auth and auth approaches. Hope to have something out by the end of the week.

  • ❤️1
mhalomari commented

Thanks @garrytrinder for the amazing app. It works perfectly as expected. I look forward to get the Auth issue handled. Best regards

  • ❤️1
garrytrinder commented

Thank you for the kind words @mhalomari, glad you like it.

alapinsk commented

hi @garrytrinder, thank you soo much for your effort! I am looking forward to the documentation part for this ticket.

I had a look into the changes you made on the authentication branch but I am really struggling now to understand how to run the application and which settings I need to provide in the .env files to make it work.

I have backend demo app deployed with authentication enabled and application registration / enterprise application created on Azure.

  • 👍1
garrytrinder commented

Apologies for the delay in getting back to you on this, unfortunately I've hit a bug implementing authentication in the bot using the Teams AI library and I have been waiting for an update to be released to the package with fixes, however it has not yet been released.

  • 👍1
shenghanAirWalk commented

@garrytrinder Hello, just want to check with you if the authentication in the bot is working now? Thank you very much for your hard work.

garrytrinder commented

@shenghanAirWalk I am currently testing some updates to the authentication flow in Teams AI library, unfortunately these updates are not yet public, but hope that they will be released in the coming weeks. I'll drop an update on this issue when I know more.

garrytrinder commented

On hold until implementing #9 which will enable this scenario.

  • 👍1
garrytrinder commented

#9 has been completed.