Target .NET Standard 2.0 and 2.1
NikolayIT opened this issue · 14 comments
Hey @NikolayIT can you provide some details for this issue?
Hello @garvincasimir
you are targeting .NET Standard 1.6 for your great library but it downloads a lot of dependencies when installing on .NET 5.0. If you add a target to .NET Standard 2.0 or 2.1 or target .NET Core 5.0 directly there will be no additional packages downloaded and installed as dependency to your library.
Now targets 2.0
Thank you very much! An upload to NuGet would be great. :)
Can you also provide .NET core 5 and .NET Core 6.
The old targets are not supported anymore if you get a new win10 20H11 OS laptop they all dont let you downgrade.
BTW this is cool too.. https://github.com/grid-js/gridjs
@weedkiller if I understand the .net versioning scheme correctly, the net standard 2.0 target should be sufficient for those platform versions. Please let me know if I am missing something.
In terms of gridjs, I took a quick look and I noticed it doesn't have built in xhr functionality. That is required to support server side filtering, paging and sorting. As far as I can tell it just loads all the data from the server and treats it as local from that point. If there is something I missed please let me know.
Do you plan to upload it to NuGet :)
Should be up there now
Thank you so much! And do you plan to update the dependencies to newer versions :)
- Microsoft.Extensions.Primitives
- System.Linq.Queryable
- System.Reflection.TypeExtensions
There quite a few dependencies that are different in .NET 5 & 6, like EF Core/EF 6 and mainly nugets and such. I am migrating something now, and I will let you know what I find.
BTW your parser is Awesome!
@NikolayIT I can change this but I am not sure what the benefit would be. If you are using newer versions in your project those take priority: https://docs.microsoft.com/en-us/nuget/concepts/dependency-resolution#nearest-wins. Even if not referencing directly the lowest required version will get installed: https://docs.microsoft.com/en-us/nuget/concepts/dependency-resolution#cousin-dependencies
@weedkiller The library doesn't take a direct dependency on entity framework so we should be ok there. It is designed to work with any IQueryable.
@NikolayIT are we ok to close this issue?
Yes, thanks.