gatanaso/multiselect-combo-box-flow

Remove banner.txt

jstueckrath opened this issue · 2 comments

jstueckrath commented

I added multiselect-combo-box-flow to the (Maven) dependencies of a Spring Boot project and noticed that the application suddenly showed the MultiselectComboBox banner. I did not yet define any banner and it was no problem to replace it with an own banner, since those are loaded with higher priority. However, I would suggest to remove the banner.txt since such a behaviour is not what I would expect of a library-type dependency.

gatanaso commented

Hi @jstueckrath

Thanks for reporting the issue. I think the banner has been auto-generated when initially creating the project via the vaadin plugin. I do agree that the component should probably not display a banner on the app level, even if the app has not set one.

jstueckrath commented

@gatanaso You're welcome, I am happy to help. Thanks also for the your combo box implementation, it fits my requirements quite nicely.