gaucho-labs/leptos-hotkeys

Build demo through GitHub CI

mondeja opened this issue · 4 comments

mondeja commented

I'm seeing that you're building the Vercel APP demo manually or with an external workflow. This surely is tedious and cause isn't automated.

Vercel can be configured to build the demo with GitHub Actions. Your VERCEL_TOKEN will be safe using action secrets. See https://vercel.com/guides/how-can-i-use-github-actions-with-vercel

friendlymatthew commented

I'm seeing that you're building the Vercel APP demo manually or with an external workflow. This surely is tedious and cause isn't automated.

Yeah, FWIW the demo seems to rebuild upon a new commit on main

  • 👍1
mondeja commented

Yeah, FWIW the demo seems to rebuild upon a new commit on main

That's probably something that we don't want, seems a bit risky and is preferable to be updated on releases to reflect new features, but for now is OK.

  • 👍1
friendlymatthew commented

@all-contributors
please add @mondeja for code.
please add @JustBobinAround for code.

allcontributors commented

@friendlymatthew

I've put up a pull request to add @mondeja! 🎉

I've put up a pull request to add @JustBobinAround! 🎉