gaul/modernizer-maven-plugin

Not java10 compat

Closed this issue · 8 comments

davidkarlsen commented

When running on a JDK 10 I get:

 Failed to execute goal org.gaul:modernizer-maven-plugin:1.6.0:modernizer (modernizer) on project jfr-srv-schemas: Execution modernizer of goal org.gaul:modernizer-maven-plugin:1.6.0:modernizer failed. IllegalArgumentException -> [Help 1]
21:29:38 org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.gaul:modernizer-maven-plugin:1.6.0:modernizer (modernizer) on project jfr-srv-schemas: Execution modernizer of goal org.gaul:modernizer-maven-plugin:1.6.0:modernizer failed.
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154)
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146)
21:29:38     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
21:29:38     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:200)
21:29:38     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:196)
21:29:38     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
21:29:38     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:514)
21:29:38     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
21:29:38     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1135)
21:29:38     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:635)
21:29:38     at java.lang.Thread.run (Thread.java:844)
21:29:38 Caused by: org.apache.maven.plugin.PluginExecutionException: Execution modernizer of goal org.gaul:modernizer-maven-plugin:1.6.0:modernizer failed.
21:29:38     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:145)
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208)
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154)
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146)
21:29:38     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
21:29:38     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:200)
21:29:38     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:196)
21:29:38     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
21:29:38     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:514)
21:29:38     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
21:29:38     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1135)
21:29:38     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:635)
21:29:38     at java.lang.Thread.run (Thread.java:844)
21:29:38 Caused by: java.lang.IllegalArgumentException
21:29:38     at org.objectweb.asm.ClassReader.<init> (ClassReader.java:160)
21:29:38     at org.objectweb.asm.ClassReader.<init> (ClassReader.java:143)
21:29:38     at org.objectweb.asm.ClassReader.<init> (ClassReader.java:418)
21:29:38     at org.gaul.modernizer_maven_plugin.Modernizer.check (Modernizer.java:80)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:290)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.recurseFiles (ModernizerMojo.java:283)
21:29:38     at org.gaul.modernizer_maven_plugin.ModernizerMojo.execute (ModernizerMojo.java:199)
21:29:38     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:134)
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208)
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154)
21:29:38     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146)
21:29:38     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
21:29:38     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:200)
21:29:38     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:196)
21:29:38     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
21:29:38     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:514)
21:29:38     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
21:29:38     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1135)
21:29:38     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:635)
21:29:38     at java.lang.Thread.run (Thread.java:844)
21:29:38 [ERROR] 
21:29:38 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
21:29:38 [ERROR]
gaul commented

Can you test with 1.7.0-SNAPSHOT? a8de2d3 and fdf996b should address this.

davidkarlsen commented

I cannot easily run with snapshot versions, but I fixed it by overriding the dependencies:

        <dependencies>
          <dependency>
            <groupId>org.ow2.asm</groupId>
            <artifactId>asm</artifactId>
            <version>6.1.1</version>
          </dependency>
          <dependency>
            <groupId>org.ow2.asm</groupId>
            <artifactId>asm-commons</artifactId>
            <version>6.1.1</version>
          </dependency>
        </dependencies>

will 1.7.0 be released soon?

  • 👍2
rbjorklin commented

Spotbugs 3.1.3 would probably be a good idea first: https://github.com/spotbugs/spotbugs/blob/3.1.3/CHANGELOG.md

gaul commented

I do not follow -- spotbugs runs in the developer environment; the produced jar does not reference it. The user environment runs modernizer that does use the asm dependency which requires upgrading to 6.1.1, either in the future modernizer 1.7.0 release or by overriding the dependency as suggested above.

rbjorklin commented

Sorry about the confusion, seems there's a lack of understanding on my part. Thanks for the explanation!

EDIT: I missed that spotbugs was under the <build> tags...

davidkarlsen commented

could you release the updated 1.7.0 version?

gaul commented

I deployed 1.7.0-SNAPSHOT with asm 6.2.1. Could you test if this resolves this issue?

davidkarlsen commented

It does - thanks