"Add to Home Screen" feature doesn't work
FluorescentHallucinogen opened this issue · 8 comments
Sorry but this is a demo for push and I'm not expecting users to add it to their homescreen
I'm not expecting users to add it to their homescreen
In this case, what manifest.json file is for? ;)
IMO, receiving push notifications from "homescreen apps" in background is very interesting use case.
Looks like it's very easy to fix, the problem is in https://github.com/gauntface/simple-push-demo/blob/master/src/manifest.json#L11
If you fix "Add to Home Screen" feature, it will be possible to add your demo to https://pwa.rocks as real Progressive Web App. ;-)
Seems it's GitHub Pages bug. Just cloned gh-pages branch and deployed it "as is" to Firebase (https://firebase.google.com) and all work like a charm! I've visited the Firebase-deployed app at least twice, with at least five minutes between visits, and Chrome for Android automatically displays "Add to Home Screen" banner. I've added it to home screen, then clicked app icon on home screen, and the app works fine.
The problem is that "/" value of "start_url" key points to https://gauntface.github.io/ URL instead of https://gauntface.github.io/simple-push-demo/. Using absolute path fixes the problem.