gavinying/modpoll

Consider upgrade `pymodbus` to version 3.2.2

cfreire opened this issue · 2 comments

cfreire commented

Hello @gavinying
Please consider upgrading pymodbus to version 3.2.2.
Reading https://github.com/pymodbus-dev/pymodbus/blob/dev/API_changes.rst, minor changes will be necessary in code.
Unless you have other plans, like waitting for 3.3for FOSS and function callbacks.
Many thanks

gavinying commented

Updated, also fixed some issues in example config file. please check the latest version 0.5.3.
Tested with pymodbus v3.2.2, and it shall also work for v3.3 according to their current plan of API changes.

cfreire commented

Testing version 0.5.3

$ pip install -U modpoll
Collecting modpoll
  Downloading modpoll-0.5.3-py3-none-any.whl (15 kB)
(...)
Successfully installed modpoll-0.5.3 pymodbus-3.2.2

Application works as expected.
Many thanks @gavinying for time and responsiveness.
cf