WebRTC demo page errors

Question

WebRTC demo page errors

Closed this issue 4 years ago · 2 comments

M0LTE commented 4 years ago

When I open https://gavv.github.io/webrtc-cli/ I get:

Creating session...
Adding microphone to session...
TypeError: Cannot read property 'sdp' of null

Chrome latest on Windows 10.

Answer 1 · 2021-01-22T16:50:51.000Z

I changed this line: https://github.com/gavv/webrtc-cli/blob/master/docs/index.html#L94 and the one below it to:

pc.setLocalDescription(offer).then(function() {
  document.getElementById('offer').value = pc.localDescription.sdp
});

since setLocalDescription is an asynchronous function that returns a promise. The localDescription is not yet set in the original code.

Answer 2 · 2021-02-21T10:27:28.000Z

@M0LTE @groberts817 thanks! I was able to reproduce the issue and apply the fix. Pushed to master. Closing this, but feel free to reopen if it's not fixed for you.