gbdev/gb-asm-tutorial

Possible typo in Jumps

Closed this issue · 4 comments

wooster0 commented

From https://eldred.fr/gb-asm-tutorial-v2/part1/jumps.html#conditional-jumps:

ld bc, Tiles.end - Tiles sets bc to the length of the tile data: Tiles.end is the address of the first byte after the tile data, so subtracting Tiles to that yields the length.

Tiles.end should probably be TilesEnd. I couldn't find this source in this repository so I wasn't able to submit a PR.

ISSOtm commented

Yeah, it is. I'm currently working on v2, though, so this is a wontfix ^^

meithecatte commented

The issue is in the v2, though

ISSOtm commented

Ah, I didn't notice because of the repo.

ISSOtm commented

Fixed locally, closing. Thanks!

  • 👍1