Repair and correct offset at once
DarkVoyage opened this issue · 6 comments
There's no such encode option yet, but if you try to add offset during repair, you will get the offset doubled and file would not be repaired properly. This is not needed too often of course, but maybe it is not such a big deal to combine two encoding modes.
It might be a better idea to zero and disable (grey-out) the 'Extra' section when the repair script is used so users aren't able to combine other changes with the repair.
I mean that this is not bug, but a feature request. And of course you can disable manual offset setting for "fix offset", "repair" and "repair and fix offset" options.
If adding a value in Extra: Offset breaks repair and doubles the offset then it is BUG or ISSUE that should be addressed whether or not your request is. Perhaps this should be added as separate issue.
There's two different variants to resolve:
- disable manual offset for repair and offset fix modes;
- fix how manual offset works during repair.
Maybe you want to leave that decision for user, if he wants to set any offset he likes during repair. So yes - setting offset during repair makes wrong offset and doesn't repair the rip. It is a bug.
In case of fix offset
, the WriteOffset
is already set to 0
while running the script:
cuetools.net/CUETools.Processor/CUESheet.cs
Line 4524 in 5aec3fb
@DarkVoyage Could you please give the build from here a try using the repair
script:
#287 (comment)
@DarkVoyage @ha-korth
A new fix has been prepared, which avoids applying the offset twice: #288
This way it is also possible to correct the offset and repair a rip in one go.