gcollet/MstatX

conflict between paper and code

Opened this issue · 0 comments

Hi,

In the paper about statistics you provide in Wiki, t(x)=lambda_t*sum_of(plogp), but in your code, in wentropy.cpp, it is col_stat[x] -= p[x][a] * log(p[x][a]); in line 119 and in trident.cpp, it is t[x] -= tmp_proba * log(tmp_proba) in line 129. Also in the paper the base of log is 2, but the base of log in c++ is 10, and it is not divided by log(2) in your script, so I'm kind of puzzled.

Looking forward to your reply and many thanks!