gdcc/pyDataverse

Authentication by API token, not parameter passing

Closed this issue · 3 comments

skasberger commented

Authentication is done by passing an API token to the class instantiation, not by passing the parameter auth to the API methods.

Remove auth and establish set of API token if passed.

Prepare

  • Get all effected functions
    • get_request() ??
    • post_request() ??
    • delete_request() ??
    • put_request() ??

Actions

  • Develop tests
  • Remove auth from API methods
  • Update request methods, so they use the member-variable api_token if set and pass it to the request function
    • get_request() ??
    • post_request() ??
    • delete_request() ??
    • put_request() ??
  • [ ]Update Docs
  • Update Docstrings
  • Run pytest
  • Run tox
  • Run pylint
  • Run mypy

Review

  • Docs

Follow-Ups

  • [ ]
pdurbin commented

As discussed during the 2024-02-14 meeting of the pyDataverse working group, we are closing old milestones in favor of a new project board at https://github.com/orgs/gdcc/projects/1 and removing issues (like this one) from those old milestones. Please feel free to join the working group! You can find us at https://py.gdcc.io and https://dataverse.zulipchat.com/#narrow/stream/377090-python

shoeffner commented

I accidentally found this issue now, and it seems to be the same as #192, which has a PR at #201.

pdurbin commented

Yes, thanks. I'll close this in favor of the newer issue and PR.