gdtk-uq/gdtk

Creating 3D blocks using the TFI constructor fails with open corner errors

Closed this issue · 1 comments

Hans Hornung has found a regression where 3D blocks created in Eilmer fails to link up their constituent surfaces properly.

object.Error@(0): TFIVolume open at corner 0 p= Vector3(0, 0, -0.0099) p_alt1= Vector3(0, 0.0108566, -0.0893) p_alt2= Vector3(0, 0, -0.0893)

This seems to have something to do with commit a8a91f6, which changed the ordering of the geometry nomenclature.

Fixed in 1aeeadc.

It looks like the newTFIVolume constructor in luavolume.d had its own copy of the face order, which had not been updated when we changed to west, east, south, north, bottom, top. The order is now taken directly from `face_name' in nomenclature.d