Fix command_failures_total documentation
gebn opened this issue · 1 comments
gebn commented
# TYPE bmc_command_failures_total counter
bmc_command_failures_total{command="Get Power Reading"} 1
bmc_command_failures_total{command="Get Sensor Reading"} 5419
The comment cannot be true as bmc_command_responses_total{code="0xcb(Unknown)"} is 5419. The command executes successfully, returning a bad status code, which is counted as a command failure. Isn't it more useful to include bad response codes - assuming we can accurately identify them?