geekcell/docker-compose-nodejs-examples

Adding dockerignore

dunckr opened this issue · 2 comments

Thanks for making these samples. It made it much easier for me to get up and running!

Pushing to server will be slow as it will copy all of the node_modules. To prevent this we can add a .dockerignore as we already do an npm install as part of the docker-compose.yml.

Do you think this would be worth adding to prevent this common trap?

@dunckr

To be honest, I haven't done anything with .dockerignore yet, but you seem to have a pretty good point 👍 Can you send a pull request?

Yeah sure no problem. It will just be something like this