geerlingguy/ansible-role-kubernetes

node-role.kubernetes.io/master -> node-role.kubernetes.io/control-plane

rdxmb opened this issue · 7 comments

rdxmb commented

Please adapt your tooling built on top of kubeadm to use the "node-role.kubernetes.io/control-plane" label.
The taint applied to control-plane nodes "node-role.kubernetes.io/master:NoSchedule" is now deprecated and will be removed in a future release after a GA deprecation period.
Apply toleration for a new, future taint "node-role.kubernetes.io/control-plane:NoSchedule" to the kubeadm CoreDNS / kube-dns managed manifests. Note that this taint is not yet applied to kubeadm control-plane nodes.

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.20.md#no-really-you-must-read-this-before-you-upgrade

geerlingguy commented

What is this in relation to?

rdxmb commented 
# kubectl get nodes eins -o yaml | grep -1 NoSchedule
  taints:
  - effect: NoSchedule
    key: node-role.kubernetes.io/control-plane

kubeadm version: v1.20.6

geerlingguy commented

@rdxmb - Ah, thanks!

geerlingguy commented

@rdxmb - Just merged the other major PR (config change)—would you like to take a stab at cleaning this up now?

rdxmb commented

hm,

  1. whats the goal here? Use both of the labels? Or only one of them?
  2. What about the comment in https://github.com/geerlingguy/ansible-role-kubernetes/blob/master/tasks/master-setup.yml#L79 We should fix this in one step.
geerlingguy commented

See: #126 — this will be a breaking change in the next major release of the role.