geerlingguy/ansible-role-postgresql

Setting ssl on/off results in duplication postgresql.conf lines.

r-pufky opened this issue · 3 comments

Similiar to issue #176

Before running

host_vars

postgresql_global_config_options:
  ...
  - option: ssl
    value: 'off'

/etc/postgresql/11/main/postgresql.conf

...
ssl = on
...

After running task

/etc/postgresql/11/main/postgresql.conf

...
ssl = on
... rest of ssl block ...
ssl = 'off'
...

Note: Using boolean interpreted values here (e.g. host_vars value: off results in ssl = False in the conf)

Again, maybe postgresql.conf should be managed from a template with defaults instead generic regex's? Regex is notorious difficult to get right.

I have the same issue with ssl

In variables -

postgresql_global_config_options:
  - option: ssl
    value: on

results in -

# - SSL -

ssl = on
... (output clipped) ...
ssl = 'True'
stale commented

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale commented

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.