geissdoerfer/shepherd

Disabling Comment in Sync Loop causes Timeout

borro0 opened this issue · 1 comments

Since this log is kinda floading the kernel logs I wanted to comment it out, but that causes a timeout while running record:

printk(KERN_INFO "shprd: ERR: %lld CORR: %d", err,
ctrl_rep->clock_corr);

Result when code is commented out

command used: sudo python3 cli.py record -l 3
error:
shepherd.sysfs_interface.SysfsInterfaceException: timed out waiting for state running - state is idle

dmesg | grep shepherd:

[ 845.073347] shepherd virtio1.rpmsg-shprd.-1.1: timeout waiting for a tx buffer
[ 845.080691] shepherd virtio1.rpmsg-shprd.-1.1: rpmsg_send failed: -512

Thanks for reporting. I couldn't reproduce the issue, i.e. everything was working even after removing the print statement for me. Anyway, you're right that the messages flood kernel logs. This has been fixed with 7afac7e.