geluk/pass-winmenu

"Open Shell" command fails for users with apostrophe in username

Sgt-Nukem opened this issue · 3 comments

Sgt-Nukem commented

With a username (and thus profile directory) like xxxxxxit 'k' the "Open Shell" command which opens PowerShell with correct GPG path is unusable:

image

Parsing of the path to the GPG executable stops at the first occurence of an apostrophe. This needs to be escaped.

geluk commented

Hi @Sgt-Nukem, I have created a new build in which the arguments to the gpg command are escaped properly. Can you check if this solves your issue?

You can download the executable here: https://ci.appveyor.com/api/buildjobs/0vttj2pb796d0ofy/artifacts/pass-winmenu%2Fbin%2FRelease%2Fpass-winmenu.exe

Sgt-Nukem commented

Hi @Sgt-Nukem, I have created a new build in which the arguments to the gpg command are escaped properly. Can you check if this solves your issue?

I just did the regular upgrade to 1.13.1 - but now it won't start at all: c.f. issue #110

Sgt-Nukem commented

Hi @Sgt-Nukem, I have created a new build in which the arguments to the gpg command are escaped properly. Can you check if this solves your issue?

The "Open Shell" command now works as expected since re-release of 1.13.1 - thanks.

  • 🎉1