View button in /go-cam for model should point to Alliance Pathway Viewer

Question

View button in /go-cam for model should point to Alliance Pathway Viewer

dustine32 opened this issue 2 years ago · 12 comments

dustine32 commented 2 years ago

Title explains (most of) it all:

This View button should go to:

Not to the Noctua editorial interface.

@tmushayahama already has the code change in a branch. I can merge the change and deploy to AWS.

Tagging @thomaspd @kltm

Answer 1 · 2022-10-03T22:20:47.000Z

@dustine32 @tmushayahama Could you link the branch?

Answer 2 · 2022-10-03T22:21:06.000Z

Or setup a PR so we can see the code/link changes? <-- preferred

Answer 3 · 2022-10-03T22:38:54.000Z

@kltm Ah crud, you're right. Sorry! The branch is creatively named "dev": https://github.com/geneontology/web-gocam/commits/dev

I just realized there were a lot of formatting changes that clutter the changes relevant to this ticket (noctuaAlliancePathwayViewUrl env var, getAlliancePathwayView function, hook function into browse-models.component.html). I also need to remove the URL change to point back to the regular go-public endpoint for fetching the JSON files. Thinking of just copying the relevant changes to a new branch and PR.

Answer 4 · 2022-10-03T22:43:18.000Z

No worries, sometimes things get confused. Operationally, the change would be:

  noctuaAlliancePathwayViewUrl: 'http://noctua.geneontology.org/workbench/noctua-alliance-pathway-preview/?model_id=',
  noctuaPathwayViewUrl: "http://noctua.geneontology.org/workbench/pathwayview/?model_id=",

?

My understanding is that we wanted to have this be an embedded widget in the /go-cam site and not have traffic heading towards the curation system.

Answer 5 · 2022-10-03T22:59:17.000Z

Correct on both @kltm. I think (@thomaspd may want to weigh in) this is a short-term fix to at least direct users to a more digestible graph. The full widget embedding could be handled in a new ticket?

Answer 6 · 2022-10-03T23:41:34.000Z

I think the question here is if this is a "project" or not. If @thomaspd and @pgaudet agree, I'm more than happy to take this as a software maintenance ticket, but we do need to track both of these.

Answer 7 · 2022-10-04T00:03:57.000Z

Yes, this would be fine as a maintenance ticket. I think we're all in agreement that the public GO-CAM site should not point to our curation tool, and it's important to provide a visualization of these GO-CAMs so our users can understand what each of them represents.

Answer 8 · 2022-10-04T00:23:12.000Z

@thomaspd I think the technical point that I miscommunicated is that this is still pointing to our curation tool and creating system traffic, load, and hinting bots. I agree that this is an improvement (getting rid of the login button if nothing else), but I still think we need to prioritized the "stronger" version of this much sooner than later.

Answer 9 · 2022-10-06T20:31:36.000Z

@tmushayahama Believes that the stronger version of this--having the widget open on click--is quite easy, so we will take a look at that path first.

Answer 10 · 2022-10-10T22:32:42.000Z

@tmushayahama can fill in the details but we discussed (with @thomaspd) that there is some Angular version issue that makes implementing the "on click widget open" much more difficult than expected. So, for a short-term fix, I can PR this change f648a87 and deploy.

Answer 11 · 2022-10-10T22:43:48.000Z

@tmushayahama @dustine32 Yes, it would be good to get the details here for review.

Answer 12 · 2022-12-07T01:36:51.000Z

Pulling this out of project for keeping traffic away from curation interfaces.