genicam/harvesters

Deprecation warning when run_as_thread is used

xander-m2k opened this issue · 2 comments

xander-m2k commented

Describe the Issue
When you start the image acquirer with run_as_thread there are some deprecation warnings about timeout_on_client_fetch_call. Namely:

To Reproduce
Steps to reproduce the behavior:

  1. Run ImageAcquirer.start(run_as_thread=True)

Sample Code
I can show a piece of code that demonstrates the reported phenomenon:

  • Yes (already did)
  • No

If applicable, please paste the actual output (its whole traceback, etc) here:

/home/<user>/.cache/pants/named_caches/pex_root/venvs/s/8f6cd2f6/venv/lib/python3.9/site-packages/harvesters/core.py:2314: DeprecationWarning: please consider to use timeout_period_on_client_fetch_call instead of timeout_on_client_fetch_call.
  timeout_on_client_fetch_call=self.timeout_on_client_fetch_call)

Expected Behavior
No deprecation warnings, I don't feel like it's necessary to a lot more information, it's just the case of replacing the function in core.py. I guess it's just a little weird that the library itself uses a deprecated function.

JeremyKeusters commented

Copy of #403

  • 👍2
sunavlis commented

Release 1.4.3 includes the merge request and is now available on PyPI.

Thanks for reporting and provide a solution for this issue!