Missing characters, data required

Question

Missing characters, data required

tawan475 opened this issue 3 years ago · 7 comments

tawan475 commented 3 years ago

简述此故障/Describe the bug

Read Title

如何重现此故障/To Reproduce

Install Genshin-Kit
run new util.CharacterNickname().getNicknamesById(10000002);

THE 10000002 CHARACTER IS MISSING

Go in ./node_modules/genshin-kit/lib/util/CharacterNickname.js Line: 28
There is suppose to be 10000002 (Ayaka) present, but not.

The temporary fix is to just add back in

  {
    id: 10000002,
    nicknames: [
      '神里绫华',
      'kamisatoayaka',
      'shenlilinghua',
      '白鹭霜华',
      '绫华',
      'ayaka',
    ],
   },

Please update in main release

本应出现的情况/Expected behavior

Return array of nicknames for 10000002

环境信息/Your environment

genshin-kit: latest
Node.js: v14.5.0
系统/OS: Windows

tawan475 commented 3 years ago

2.4.1

Answer 1 · 2021-09-14T15:02:08.000Z

Hi, what is your exact version of genshin-kit.

Answer 2 · 2021-09-14T16:01:47.000Z

Also kazuha is missing (10000047)

Answer 3 · 2021-09-14T16:06:34.000Z

You may want to use 2.4.2, this has been added.

Answer 4 · 2021-09-14T16:09:59.000Z

For 10000047 you can make an pr

Answer 5 · 2021-09-14T16:17:47.000Z

ive added kazuha in this pull request #35

Answer 6 · 2021-09-14T16:27:21.000Z

after some quick checking in src/util/characterNickname.ts there are still some missing characters
eula and traveller - can't find the data myself (the ID)