chain doesn't propagate after gap return zero_results

Question

chain doesn't propagate after gap return zero_results

AlmogBaku opened this issue 7 years ago · 10 comments

chain doesn't propagate after gap return zero_results:

bazinga_geocoder:
  providers:
    gmap:
      cache: 'app.simple_cache'
      cache_lifetime: 3600
      factory: Bazinga\GeocoderBundle\ProviderFactory\GoogleMapsFactory
      options:
        api_key: '%env(GMAPS_API)%'
    opencage:
      cache: 'app.simple_cache'
      cache_lifetime: 3600
      factory: Bazinga\GeocoderBundle\ProviderFactory\OpenCageFactory
      options:
        api_key: '%env(OPENCAGE_API)%'
    chain:
      factory: Bazinga\GeocoderBundle\ProviderFactory\ChainFactory
      options:
        services: ['@bazinga_geocoder.provider.gmap','@bazinga_geocoder.provider.opencage']

I can see in the profiler that there was a query for gmap but not for opencage.

AlmogBaku commented 7 years ago

@Nyholm

Answer 1 · 2017-10-13T00:57:11.000Z

Thank you.
What does the Google provider return?

Answer 2 · 2017-10-13T00:58:07.000Z

zero_results

Answer 3 · 2017-10-13T01:01:15.000Z

Are you talking about a ZeroResultException? Are you using the latest version of the bundle? 5,0?

Answer 4 · 2017-10-13T01:02:14.000Z

I'm using the master

On Fri, Oct 13, 2017 at 4:01 AM Tobias Nyholm ***@***.***> wrote: Are you talking about a ZeroResultException? Are you using the latest version of the bundle? 5,0? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#170 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGCpk5eYMh10OFTpxthWUgbgoYF3hq_ks5srrZbgaJpZM4P3laM> .

-- <http://www.rimoto.net/> www.rimoto.com <http://www.rimoto.net/> *Almog Baku* *CTO & Cofounder * Mobile: +972.50.2288.744 Social: * <http://www.facebook.com/AlmogBaku> <http://www.linkedin.com/in/almogbaku>*

Answer 5 · 2017-10-13T02:21:43.000Z

Im not sure what zero_results is. If you using the latest version of the bundle and geocoder. In previous versions there was a zero_results but not in the latest...

Answer 6 · 2017-10-13T04:27:49.000Z

I meant that this the response when I'm doing a reverse query to gmaps and gmaps isn't able to resolve it(gmaps returns zero_results)

On Fri, 13 Oct 2017 at 5:21 Tobias Nyholm ***@***.***> wrote: Im not sure what zero_results is. If you using the latest version of the bundle and geocoder. In previous versions there was a zero_results but not in the latest... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#170 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGCpimAOocLY5hEufb2zJzu-4NN4Th3ks5srsk3gaJpZM4P3laM> .

-- <http://www.rimoto.net/> www.rimoto.com <http://www.rimoto.net/> *Almog Baku* *CTO & Cofounder * Mobile: +972.50.2288.744 Social: * <http://www.facebook.com/AlmogBaku> <http://www.linkedin.com/in/almogbaku>*

Answer 7 · 2017-10-13T16:47:50.000Z

So if you debug Chain::reverseQuery() the $result is not empty, correct?

Answer 8 · 2017-10-18T07:50:12.000Z

not sure what you asked...

When I call reverseQuery with the chain, it returns me an empty result since the first chain(google) respond with zero_results, however- if I reorder the chain order(first opencage and then gmap) it work

Answer 9 · 2018-09-08T07:59:47.000Z

You say:

it returns me an empty result since the first chain(google) respond with zero_results

What is zero_results? There is nothing I know that is called zero_results. :/

I know this PR has been sitting for about a year. Please come back with a possible fix or workaround.