geocoder-php/BazingaGeocoderBundle

Custom vendor location symfony 4

celsoandrade opened this issue · 5 comments

celsoandrade commented

Hi,

When I add custom vendor location in composer.json using symfony 4

{
    "config": {
        "bin-dir": "bin",
        "vendor-dir": "/some/dir/vendor"
    },
}

symfony starts to throw a message geocoder file not found.
FileLocator.php
The file "/app/vendor/willdurand/geocoder/Dumper" does not exist.
For some reason it ignores vendor-dir from composer.json and search for file in the default vendor dir.

thank you

celsoandrade commented

Searching the code I think the problem is here:

services:
    Geocoder\Dumper\:
        resource: '%kernel.project_dir%/vendor/willdurand/geocoder/Dumper'
        public: true
        tags: ['bazinga_geocoder.dumper']
Nyholm commented

Thank you for this issue. You are correct. Could you make a PR to fix this issue?

celsoandrade commented

Sorry I don't know how to solve this.

Nyholm commented

No worries, We do it together.

  1. Do you know what code changes to be made to fix this problem?
  2. Have your read this? https://help.github.com/articles/creating-a-pull-request/
celsoandrade commented

I'm searching for a fix..
I know how to PR