integer cast on cache_lifetime return 0 instead of null if not provided

Question

integer cast on cache_lifetime return 0 instead of null if not provided

lwillems opened this issue 5 years ago · 2 comments

in BazingaGeocoderExtension

$container->register($providerServiceId.'.cache', CachePlugin::class) ->setPublic(false) ->setArguments([new Reference($cacheServiceId), (int) $config['cache_lifetime'], $config['cache_precision']]);

casting argument as (int) make it default to 0 in cachePlugin __construct instead of null if provided in yaml conf :
cache_lifetime: ~

Consequence : infinite caching is not possible

Regards

Answer 1 · 2019-07-08T09:54:02.000Z

Hello @lwillems, would you like to submit a PR to fix this?

Answer 2 · 2019-09-20T11:24:38.000Z

@lwillems this was fixed in #249