geocoder-php/GeocoderLaravel

I need to purge the empty cached results, how?

adddz opened this issue · 7 comments

adddz commented

As many others already mentioned, the library caches empty results (empty collections). All good up to here, but how can I purge those results?

adddz commented

I guess nobody is maintaining this repo anymore? :(

mikebronner commented

@adddz Sorry for the late reply. Right now to purge those you would do something like php artisan cache:clear.

mikebronner commented

Just released 4.4.5 with the PR that clears items from cache.

adddz commented

Just released 4.4.5 with the PR that clears items from cache.

Hi Mike, thank you so much.

Will this work even for when an address gets assigned latitude and longitude 0.000000?

mikebronner commented

@adddz unfortunately not. It will only remove the empty results. I'll be happy to consider a PR, if you have time to submit one.

adddz commented

@adddz unfortunately not. It will only remove the empty results. I'll be happy to consider a PR, if you have time to submit one.

Sure. Just to understand, let's say the geocoder returns 0.000000 as lat/lng for an address, will it still save it in the cache then? I was thinking of adding a method to the geocoder that removes only a specific item from the cache.

mikebronner commented

I believe that is correct: https://github.com/geocoder-php/GeocoderLaravel/pull/186/files#diff-acda5d354b2c91ce241087f5ae72c8c836de52a45ab812a69f2b5294fe9266c0R322

Perhaps you can add the appropriate logic there, if it makes sense to do so.

  • 👍1