geocoders/geocoder-tester

Reports error although no visible difference

Closed this issue · 5 comments

I get the following result:

Search failed
# Search was: Bautzener
# Params was: lon: 14.260983 - limit: 1 - lat: 51.440661
# Expected was: country: Germany | name: Bautzener Allee | postcode: 02677
# Results were:
name            | osm_key | osm_value | osm_id    | housenumber | street | postcode | city        | country | lat        | lon        | distance
--------------- | ------- | --------- | --------- | ----------- | ------ | -------- | ----------- | ------- | ---------- | ---------- | --------
Bautzener Allee | highway | tertiary  | 388210833 | —           | —      | 02977    | Hoyerswerda | Germany | 51.4405684 | 14.2610365 | —       

for a location bias request:

comment;query;lat;lon;expected_name;expected_country;expected_postcode
Hoyerswerda;Bautzener;51.440661;14.260983;Bautzener Allee;Germany;02677

which does not make any sense to me, because I cannot see any difference, also not from the pytestdebug.log

The raw geocoder response is:

{"features":[{"geometry":{"coordinates":[14.2610365,51.4405684],"type":"Point"},"type":"Feature",
"properties":{"osm_id":388210833,"osm_type":"W","extent":[14.2609224,51.4406793,14.2614896,51.4401282],
"country":"Germany","osm_key":"highway","city":"Hoyerswerda","osm_value":"tertiary",
"postcode":"02977","name":"Bautzener Allee","state":"Saxony"}}],"type":"FeatureCollection"}

It would be good if one could see which of the expected objects failed.

Uups postcode is wrong ;) ... but it would be helpful if this is easier to find out via more detailed logs instead of removing column by column

We may display in bold each value that does not match in each column.

Or red :) ... or just assume people that can read ;)

Yeah, red sounds better :)

Thanks!