geokrety/geokrety-website

Error when changing the birth date

Closed this issue · 23 comments

kumy commented

doh! @GGGuerin Do you have the same issue if you switch the side in English?

kumy commented

I'm not able to reproduce :/

kumy commented

Do you see something special in the Firefox developper console?

kumy commented

I was able to reproduce with your GK, my guess is it's related to the archiving state, let's see 👁️

It's related to the user's language datetime format, working in English
image

OK .... when I work in english, I can change the birthdate.
But when i create a move younger than the new birthdate, it does not work ....
Capture d’écran 2024-05-21 à 18 55 14
Capture d’écran 2024-05-21 à 18 55 24

kumy commented

I think I've fixed both issues, I just pushed the commits it should be live on staging https://staging.geokrety.org/ in a a few minutes. @GGGuerin Please test there and keep me posted :)

kumy commented

(FTR Another user reported the first issue via support)

🎉 This issue has been resolved in version 2.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

New issue ... Birth date is older than the date of the move
Capture d’écran 2024-05-23 à 08 16 53

kumy commented

@GGGuerin I was able to post the same log as in your screenshot
https://geokrety.org/en/geokrety/GK180EF/page/1#log5385466

@GGGuerin I was able to post the same log as in your screenshot https://geokrety.org/en/geokrety/GK180EF/page/1#log5385466
Let me do a trial ;-)

This GK was "initially" created one or two days ago. So if you try to log before this initial birthdate, it does not work ....
Capture d’écran 2024-05-23 à 17 29 36

kumy commented

Ha French... let me try in French. Could you try the English version on your side 🙏

Trial in english....
Capture d’écran 2024-05-23 à 17 34 40

kumy commented

Yep, I saw you in the logs ;)
Still trying to understand what could be the issue

Yep, I saw you in the logs ;) Still trying to understand what could be the issue

It seems that it does take into account the "initial" birth date, doesn't it ?

kumy commented

It seems that it does take into account the "initial" birth date, doesn't it ?

yes :(

I was finally able to reproduce 🥳

kumy commented

I think I have the root cause and the fix in this PR https://github.com/geokrety/geokrety-website/pull/1017/files. Now I want to have the unit tests fixed. That should have been detected 😈

🎉 This issue has been resolved in version 2.50.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kumy commented

v2.50.1 is deployed
image

It works ! Great !
Thanks