geoph9/hass-gshell-extension

Gnome 41 related

Closed this issue · 2 comments

These issues were in a review of the extension by @JustPerfection in e.g.o.:

  1. Also do this on disable:
    hassExtension = null;

  2. Lang is a deprecated module. Please remove it for the next version:
    https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice
    Learn how to remove Lang from your code:
    https://gjs.guide/guides/gjs/legacy-class-syntax.html

Also remove getSettings from utils.js. Use ExtensionUtils.getSettings() instead. and remove unnecessary lines here and here. When you have this line in metadata.json file you don't need to send the parameter.

Thank you for your help and pointers! These were all fixed in b318414