Build script references a different filename than current releases
Closed this issue · 2 comments
Both versions 44 and 45 have a filename like:
https://github.com/geoph9/hass-gshell-extension/releases/download/45/hass-gshell@geoph9.zip
instead of what the build script looks for of hass-gshell@geoph9-on-github.shell-extension.zip
hass-gshell-extension/build.sh
Line 41 in c2d0236
Either the releases should be updated to have the correct filenames or the script should try both I believe
(As a note, I'm trying the build script as the Gnome 45 release still hasn't been updated to https://extensions.gnome.org/extension/4170/home-assistant-extension/ )
Hi @Peter200lx , thanks for noticing this! I'll make the necessary changes right away. I'll also try to republish the gnome 45 version at e.g.o (last time it was rejected because I failed to follow all of the guidelines).
Building using build.sh
should work now (I just changed the filenames of the releases so that I wouldn't have to make unnecessary url checks in the script).
I also uploaded the most recent version over at e.g.o. and I am awaiting for a review. I think my changes follow all new guidelines, but it's quite possible I might have missed some. In any case, I will be closing this now.