georgian-io/Multimodal-Toolkit

Bug in method "attention_on_cat_and_numerical_feats"

Jordy-VL opened this issue · 1 comments

Jordy-VL commented

Multimodal-Toolkit/multimodal_transformers/model/tabular_combiner.py

Line 268 in 8f5b64d

self.cat_mlp = MLP(

There is a bug in the method "attention_on_cat_and_numerical_feats", where if you have both categorical and numerical features, the MLP defined as self.cat_mlp gets overwritten instead of initializing self.num_mlp.

akashsaravanan-georgian commented

Closing as this is a duplicate of #14.